client: allow nil body in DoJSON#2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the kbhttp JSON client helpers to support requests where callers intentionally do not want to decode a response body (e.g., 204 No Content responses).
Changes:
- Documented that
DoJSON/GetJSON/PostJSON/PutJSON/DeleteJSONallow passingnilas the decode target to skip decoding. - Updated
Client.DoJSONto return early whentarget == nil. - Added a test asserting
DoJSONsucceeds with aniltarget on a204 No Contentresponse.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
client.go |
Adds documentation and implements early-return behavior when target is nil. |
client_test.go |
Adds coverage for DoJSON(req, nil) when the server responds with HTTP 204. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Since target is already an interface, no need for more indirection, it could cause unexpected behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.