Josh/review round 1 - #1
Merged
Merged
Conversation
The toolbox's clock, ping and ping-fail are no longer excluded and copied: the migrator's own stamp is clock-phase, the step after clock, and its ping command, the Runtime field behind it and their tests are gone, since the toolbox pings HEALTHCHECK_URL, which is now the op.env name. Task bodies read the toolbox's RUN instead of a literal .run, and the env block drops the two paths that were the migrator's own defaults and the no-op default filters. The workflows pin lib's release commit like the sibling mirrors, with a dependabot.yml to bump them, and the PR check is one job: render, tests and lint from one runner and one image pull. .taskrc.yml names the key task reads, cache-expiry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor and review
Test plan
task renderpasses and the committed render was updated if the commands changed