Refactor to extract and import shared utility functions - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Extracts the duplicated toTitleCase and formatDefaultTitle text utilities into a single shared module and rewires both layout components to import them, removing all duplicate implementations.
Changes Included:
Shared module: Added src/utils/text.ts with toTitleCase and formatDefaultTitle as the single source of truth.
AppShell: Removed its local copies and imports from the shared module (4 call sites unchanged).
SettingsModal: Removed its local copies and imports from the shared module (2 call sites unchanged).
Scope note: The roadmap listed DoomsdayTool as a third consumer, but PR 27 already removed its only toTitleCase usage, so including it would have created a dead import. SettingsModal was added because the roadmap's own acceptance criterion (grep "const toTitleCase" returns exactly one result) requires all duplicates gone.