Improve accessibility and code quality across components - #50
Merged
Conversation
… self-closing tags
…ics across modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Accessibility and lint cleanup. Module tools get labels tied to their inputs, keyboard-operable controls, and SVG titles. Biome lint drops from 83 diagnostics to zero.
Changes Included:
CoreBitRow: bit toggles use real checkboxes.
Sidebar menu: list items became native buttons; removed role="menu" and role="menuitem", which had no menu behavior behind them.
Date picker trigger: now a button.
Labels wired with htmlFor/id across module tools: Caesar, Morse, NATO, Braille, Semaphore, Hex, Roman, Rule 72, EAN, ASCII, Color Theory, Storage Units, Doomsday, Ordinal, Periodic Table.
ASCII table and periodic table cells are buttons.
SVG titles added: logo, semaphore figure, resistor diagrams.
Biome fixes: parseInt radix, Number.isNaN, type-only React imports, guarded root lookup in main.tsx.
Tests updated for the new controls; user-event added as a dev dependency.
Type of Change
Checklist
npm run checkpasses (Biome lint & format)npm run testpasses (all unit tests)npm run buildpasses (TypeScript strict mode)