Skip to content

Prevent data races in tests#4177

Merged
kcp-ci-bot merged 3 commits into
kcp-dev:mainfrom
ntnn:race-prevention
Jun 1, 2026
Merged

Prevent data races in tests#4177
kcp-ci-bot merged 3 commits into
kcp-dev:mainfrom
ntnn:race-prevention

Conversation

@ntnn
Copy link
Copy Markdown
Member

@ntnn ntnn commented May 29, 2026

Summary

race prevention found in #4173

What Type of PR Is This?

/kind chore

Related Issue(s)

Fixes #

Release Notes

NONE

ntnn added 3 commits May 29, 2026 12:52
@ntnn
Fix data race due to shared scheme and object
e28ae19 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Fix data race due to shared objects
88ab9db 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Assign err instead of shadowing
a845e6e 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2026
@ntnn
Copy link
Copy Markdown
Member Author

ntnn commented May 29, 2026

/retest

flake?

@ntnn ntnn added this to tbd May 29, 2026
@ntnn ntnn moved this to In review in tbd May 29, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor

mjudeikis commented Jun 1, 2026

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jun 1, 2026

LGTM label has been added.

DetailsGit tree hash: 6066f4f3f643082cc126b24c07a829520b9f6d82

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2026
@ntnn
Copy link
Copy Markdown
Member Author

ntnn commented Jun 1, 2026 

 + set +o xtrace
Command terminated with 0
Compressing build artifacts...
tar: kcp/audit.log: file changed as we read it
tar: kcp: Cannot rmdir: Directory not empty
tar: Exiting with failure status due to previous errors

o.O

/retest

@kcp-ci-bot kcp-ci-bot merged commit 53a982a into kcp-dev:main Jun 1, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in tbd Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntnn @mjudeikis @kcp-ci-bot