Skip to content

Fix jpg_quality/jpeg_quality field mismatch with OCRmyPDF >=17.10 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-- merged 3 commits into from
Aug 12, 2026
Merged

Fix jpg_quality/jpeg_quality field mismatch with OCRmyPDF >=17.10 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2781cf
Fix jpg_quality/jpeg_quality field mismatch with OCRmyPDF >=17.10; de…
tah0 Aug 10, 2026
d176ddf
Revert "Fix jpg_quality/jpeg_quality field mismatch with OCRmyPDF >=1…
tah0 Aug 10, 2026
09908a1
Fix jpg_quality/jpeg_quality field mismatch via backwards-compatible …
tah0 Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ strict_bytes = false
module = [
"click_man.*",
"djvu.*",
"ocrmypdf.*",
#"ocrmypdf.*",
"pdfrw.*",
"uv_build.*",
]
Expand Down
4 changes: 3 additions & 1 deletion src/dpsprep/ocrmypdf_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ def run_ocrmypdf_optimizer(options: DpsPrepOptions) -> bool:
jobs=options.pool_size,
optimize=options.optlevel,
# When set to 0, OCRmyPDF's "optimize" function attempts to adjust them
jpg_quality=quality or 0,
png_quality=quality or 0,
)

# Set jpg_quality via attribute (backwards-compatible setter) rather than constructor kwarg, since the kwarg differs across OMP versions.
omp_options.jpg_quality = quality or 0

info = PdfInfo(workdir.combined_pdf_path)
context = PdfContext(omp_options, workdir.ocrmypdf_tmp_path, workdir.combined_pdf_path, info, None)

Expand Down
Loading