Repository navigation
修正:投票投影片端斷線後重送目前這頁的開題/離開狀態 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an outage consumes retries on one slide and the presenter then navigates,
navTryretains the previous slide's count because it is reset only after success or anonline/WebSocket-open event. If it has already reached 8, the new slide's first failed request setsnavWaitbut schedules no retry here; when the browser remains online and the existing WebSocket stays open (for example, a transient HTTP/control-path failure), recovery emits neither event, so the backend can remain on the old poll indefinitely. Reset the counter when starting a new navigation sequence.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已在 615fa50 修正:
onShow每次換頁都會把navTry歸零,所以每一頁各有 8 次重送額度。已用 Playwright 驗證:WebSocket 一直開著、瀏覽器也在線,只有/api/control回 500。先在 warmup 用完 8 次重送,再換到非投票頁。修正前,{poll:null}失敗 1 次之後就不再送,後端停在舊題;修正後會持續退避重送,控制路徑恢復後就送成功,後端active=null。