Skip to content

Changes to README; Added opt-in command to Dockerfile; small changes on pom and ExamplePlugin.java #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlosjepard wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes to README; Added opt-in command to Dockerfile; small changes on pom and ExamplePlugin.java #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbe1fd5
Changes to README; Added opt-in command to Dockerfile
carlosjepard Mar 14, 2023
f71192a
fixed
carlosjepard Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ COPY target/${PLUGIN} ${RODA_HOME}/config/plugins/${PLUGIN}/
USER root
RUN ${RODA_HOME}/config/plugins/${PLUGIN}/install_dependencies.sh
USER ${RODA_USER}
RUN echo "core.plugins.external.certificates.opt-in=true" > /roda/config/roda-core.properties
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ It includes:
* Quick run instructions
* README automatic generation instructions


> In order to make it possible to see your creations, you must assure that you have these pre-requisites.

- [Roda Standalone](https://github.com/keeps/roda/tree/master/deploys) (Use Standalone Development, don't open WUI in spring boot)
Copy link
Contributor

@006627 006627 Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link does not lead the developer to use docker-compose-dev, which causes a conflict with port 8080, please include the step-by-step guide here

Copy link
Contributor

@006627 006627 Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command to generate the plugin documentation also does not work, please review.


## How to build and run

To build execute `./build.sh`, this will run with the latest RODA version.
Expand All @@ -20,7 +25,7 @@ The build script will compile the plugin and create a docker image with the base
To run execute (roda-plugin-template should be replaced by the project folder name):

```shell
docker run -p 8080:8080 roda-plugin-template:latest
docker run --network="host" -p 8080:8080 roda-plugin-template:latest
```

Then open in your favorite browser [http://localhost:8080](http://localhost:8080).
Expand Down