You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
double tileSize -> int tileDimension is the biggest change throughout; I'm not 100% sure where the boundary is to stop renaming and changing the type - I guess the stylesheet must keep "tileSize"?
The vector tile layer does not yet support unbounded horizontal scrolling
At some point, some coordination is planned to create a more versatile flutter_map tile layer, which can be more easily extended for a raster layer within FM, and other vector layers. This will mean a reduction of copied code, benefit from updates to the tile layer handler, and mean unbounded horizontal scrolling will be free. Other existing plugins can also take advantage of this.
Should be ok to rename it to tileDimension everywhere (including in shaders), if it'll benefit the consistency. The spec doesn't have a notion of "tileSize", it's up to the implementation.
and mean unbounded horizontal scrolling will be free
How does flutter_map handle this? Does it:
a) Draw each tile multiple times - e.g. draw each tile separately for each visible repetition of the world
b) Draw the entire world again - meaning, we render the world once, and then re-use the same world texture for the repetitions
First one would result in some performance penalties with the current implementation, since it'll require additional draw calls. However, the second one should be OK in terms of performance, since we can take the ui.Image that was created as a part of the "main world rendering", and then re-use that image to paint the visible world repetitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work in progress.
double tileSize->int tileDimensionis the biggest change throughout; I'm not 100% sure where the boundary is to stop renaming and changing the type - I guess the stylesheet must keep "tileSize"?At some point, some coordination is planned to create a more versatile flutter_map tile layer, which can be more easily extended for a raster layer within FM, and other vector layers. This will mean a reduction of copied code, benefit from updates to the tile layer handler, and mean unbounded horizontal scrolling will be free. Other existing plugins can also take advantage of this.