wip: implement writeFile and writeFileSync#7
wip: implement writeFile and writeFileSync#7erizocosmico wants to merge 1 commit intokennetpostigo:masterfrom
Conversation
|
@erizocosmico Thank you for this! So right now I wouldn't worry about the callback return. |
|
@erizocosmico instead of an encoding object we could just use a encoding string instead, in the node.js docs it says you could use either. |
|
Hey @erizocosmico , The project has been renamed to |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
aa21361 to
9cee703
Compare
|
@kennetpostigo done! So, if we're going with |
|
@erizocosmico I think we should make the user encode the string before saving the byte chunk that way it's explicit of what is going on, do you agree? |
Hi there! I've implemented a very early stage
writeFileandwriteFileSync. There's a few issues right now that I'd like to get some feedback ondatashould either bestringorbytes. I saw thatwriteused onlybytes, so I went with that for now. Should I add both, string and bytes or leave it just with bytes? If we decide to go withbytesonlyencodingwould not be needed (which is why it's not being used right now).write, since node api does not give anything other than the error. Should I return it?Tests are missing yet