Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f83e4da. Configure here.
chruffins
requested review from
Sayan- and
rgarcia
and removed request for
rgarcia
October 19, 2026 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Overlap with #463
Checked open PR #463 first. It changes process lifecycle and
process.go, but its description explicitly excludes TTY sessions from output capture; it does not cover PTY attach replay or ordering. This PR changes the same file, so a merge conflict with #463 is possible. The PTY changes are otherwise separate from #463's non-TTY output lifecycle work.Validation
cd server && go test -race ./cmd/api/api -run 'TestPTYOutput' -count=10cd server && go test ./cmd/api/api -count=1cd server && go vet ./cmd/api/api