Repository navigation
etsy.com: find the listing page's own favorite button in set_favorite - #140
Merged
Merged
Conversation
yummybomb
marked this pull request as ready for review
October 28, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_favoritereturnedlisting_not_on_pageon the listing page itself. Its selector requireddata-ui="favorite-listing-button". Only result and recommendation cards carry that attribute. The listing page's own heart isbutton.listing-page-favorite-button[data-listing-id](data-testid="favorite-heart") and has nodata-ui. The selector now also matches that button, so the tool presses it rather than a card's.The live page also has an "Add to collection" button with the same listing id. The selector does not match it, and the tests now check it is never pressed.
Tests
set_favoritetests fail; with this change, all 132 etsy tests pass.node --test "tests/*.test.mjs": 4482 pass.node scripts/validate-registry.mjs: valid.Live check (author, not independent QA)
Signed in, on a listing page:
false→truetrue→falseEach step was read back with
get_favorite_status, and the account ended where it started. The status staysdraftuntil independent QA.