Skip to content

doordash.com: check the host before sign-in in save_address - #141

Merged
yummybomb merged 1 commit into
mainfrom
hypeship/doordash-save-address-host-check
Oct 27, 2026
Merged

yummybomb merged 1 commit into
mainfrom
hypeship/doordash-save-address-host-check

Conversation

@yummybomb

Copy link
Copy Markdown
Contributor

Summary

On help.doordash.com, save_address told a signed-in account "The browser is not signed in to DoorDash." The dd_cx_logged_in cookie is only visible on www.doordash.com, and the sign-in check ran before the host check. The host is now checked first, so off-www pages get the existing "Run this on a www.doordash.com page..." answer. On www, a signed-out visit still gets not_signed_in, and a missing header address button still gets the wrong-page answer.

Tests

  • Added a case for a help-host page where the sign-in cookie is not visible. It fails with the old order and passes with this change.
  • node --test "tests/*.test.mjs": 4482 pass. node scripts/validate-registry.mjs: valid.

Live check (author, not independent QA)

Signed in, on help.doordash.com: the tool returned the wrong-page answer at session_check, with save_clicked: false. The status stays draft.

@yummybomb
yummybomb marked this pull request as ready for review October 27, 2026 22:46
@yummybomb
yummybomb merged commit 68df480 into main Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant