Repository navigation
doordash.com: check the host before sign-in in save_address - #141
Merged
Merged
Conversation
yummybomb
marked this pull request as ready for review
October 27, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
help.doordash.com,save_addresstold a signed-in account "The browser is not signed in to DoorDash." Thedd_cx_logged_incookie is only visible onwww.doordash.com, and the sign-in check ran before the host check. The host is now checked first, so off-www pages get the existing "Run this on a www.doordash.com page..." answer. On www, a signed-out visit still getsnot_signed_in, and a missing header address button still gets the wrong-page answer.Tests
node --test "tests/*.test.mjs": 4482 pass.node scripts/validate-registry.mjs: valid.Live check (author, not independent QA)
Signed in, on
help.doordash.com: the tool returned the wrong-page answer atsession_check, withsave_clicked: false. The status staysdraft.