Disable translucent system bars in theme, use FLAG_LAYOUT_NO_LIMITS instead - #83
Open
ketansp wants to merge 1 commit into
Open
Disable translucent system bars in theme, use FLAG_LAYOUT_NO_LIMITS instead#83ketansp wants to merge 1 commit into
ketansp wants to merge 1 commit into
Conversation
The system was painting its legacy translucent-status-bar gradient behind the clock/battery, leaving a visibly tinted band with a seam at the bottom of the status bar. windowTranslucentStatus/windowTranslucentNavigation set FLAG_TRANSLUCENT_STATUS/NAVIGATION, which draw that scrim independently of the transparent statusBarColor. Set both to false. Edge-to-edge layout is already provided by FLAG_LAYOUT_NO_LIMITS (MainActivity) plus the transparent bar colors, so the generated wallpaper now runs seamlessly under the status and navigation bars. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SPjCmnoUpqfm5D2JGfzqmg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
android:windowTranslucentStatusandandroid:windowTranslucentNavigationtheme attributes (set tofalse) and relies instead onFLAG_LAYOUT_NO_LIMITS(set in MainActivity) combined with transparentstatusBarColor/navigationBarColorto achieve edge-to-edge layout. This prevents the system from painting its legacy scrim gradient behind the status and navigation bars.Changes
Theme files (
values/styles.xmlandvalues-night/styles.xml):android:windowTranslucentStatusfromtruetofalseandroid:windowTranslucentNavigationfromtruetofalseFLAG_LAYOUT_NO_LIMITS+ transparent bar colors, avoiding the system's legacy scrimAppDrawerFragment.kt:
FLAG_LAYOUT_NO_LIMITSis the sole mechanism for edge-to-edge layoutRESIZE_BLOCKING_WINDOW_FLAGSdocumentation to note that only flags actually set on the window are cleared/restored, allowing safe listing of deprecated flags (e.g., translucent-bar flags)Implementation Details
The translucent bar theme attributes were causing the system to render a scrim gradient behind the status and navigation bars. By disabling these and relying on
FLAG_LAYOUT_NO_LIMITS(already set in MainActivity) with transparent bar colors, the wallpaper now runs seamlessly under the bars without the unwanted scrim overlay. The AppDrawerFragment's keyboard handling logic remains unchanged—it still clearsFLAG_LAYOUT_NO_LIMITSwhen the drawer is visible to allow the search bar to sit above the keyboard.https://claude.ai/code/session_01SPjCmnoUpqfm5D2JGfzqmg