make down: remove orphan containers - #13
Merged
Merged
Conversation
`docker compose down` only manages services defined in the current compose file. When a service is removed (e.g. the retired Streamlit dashboard), its container is orphaned and keeps running, so the old app stays reachable. Adding --remove-orphans makes `make down` clean those up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
--remove-orphansto themake downtarget:Why
docker compose downonly stops/removes services defined in the current compose file. When a service is removed fromdocker-compose.yml(e.g. retiring the Streamlitdashboardservice), its container becomes an orphan thatmake downleaves running — so the old app stays reachable on its old port and a reload "looks unchanged" even aftermake down && make up.Hit this exact case during the front-end cutover: the old
workshop-dashboard-1kept serving:8501for hours after the service was removed.--remove-orphanscleans these up automatically.🤖 Generated with Claude Code