Remove travis, add github workflow - #211
Merged
Merged
Conversation
zoom-ua
approved these changes
Sep 22, 2026
zoom-ua
left a comment
zoom-ua
left a comment
There was a problem hiding this comment.
@chrisnojima @chrisnojima-zoom can you enable CI here?
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [22, 24] |
There was a problem hiding this comment.
Suggested change
| node-version: [22, 24] | |
| node-version: [24, 26] |
zoom-ua
reviewed
Sep 22, 2026
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
v7 is the latest here and below, why not use those?
Contributor
Author
There was a problem hiding this comment.
kk i just copied this over from kbpgp, ill change there as well
michalz-zoom
force-pushed
the
michal/add-ci
branch
from
September 22, 2026 16:55
91d336c to
52bc9be
Compare
michalz-zoom
changed the title
Contributor
Author
|
ok this seems to work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zoom-ua let's add github CI here.
do we need to set anything in the repository settings? I don't have access to that