cloudsmith_release: reintroduce configurable ruby_version/bundler_version with safe defaults - #90
Open
tungleduyxyz wants to merge 2 commits into
Open
cloudsmith_release: reintroduce configurable ruby_version/bundler_version with safe defaults#90tungleduyxyz wants to merge 2 commits into
tungleduyxyz wants to merge 2 commits into
Conversation
…sion with safe defaults Follow-up to #89 (revert of #88). Re-adds the ability to configure the JRuby (or Ruby) version and paired Bundler version used when with_ruby: 'true', but this time defaults both to the values already in production use (jruby-9.4.15.0 / bundler 2.6.9) instead of silently switching every existing with_ruby caller to JRuby 10 + bundler 2.7.2. Callers that want JRuby 10 (e.g. killbill-admin-ui-standalone's jruby10-upgrade branch, once merged) can opt in explicitly: with: ruby_version: 'jruby-10.0.6.0' bundler_version: '2.7.2' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #89 (revert of #88).
Re-adds the ability to configure the JRuby (or Ruby) version and paired Bundler version used by
cloudsmith_release.ymlwhenwith_ruby: 'true'— but this time the newruby_version/bundler_versioninputs default to the values already in production use (jruby-9.4.15.0/2.6.9) instead of silently switching every existingwith_rubycaller over to JRuby 10 + bundler 2.7.2, which is what #88 did and what caused:after
killbill-admin-ui-standalone'ssnapshot_release.yml(the only caller withwith_ruby: 'true') picked up the new default.Usage
Callers that actually want JRuby 10 (e.g.
killbill-admin-ui-standalone'sjruby10-upgradebranch, once ready to merge) can opt in explicitly in their own workflow file:Depends on #89 being merged first (stacked on top of it).