Repository navigation
Add typed SliM fixture values - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SliM fixture calls currently flatten every argument and result to strings, which prevents recursive lists, distinct null/void values, typed symbols, and object-valued fixture chaining. This change adds a separate runtime value model and migrates the server, wire instructions, conversion traits, and fixture proc macro to use it.
The new boundary supports recursive lists, primitives, arrays,
Option, fallible results,chrono::NaiveDatein the documenteddd-MMM-yyyyformat, custom converters, and opaque or callable object handles.callAndAssignandassignretain structured values, while responses serialize them recursively. Wrong method arity now returns the standardNO_METHOD_IN_CLASSexception, and textual lists use the documented[a, b]form.The fixture macro now validates arity before conversion, supports generic fixture types, skips associated helper functions, and reports unsupported signatures with
syn::Error. Checkedtrybuildcases cover its diagnostics. The Rust SliM README includes the manual-fixture migration path.Validation:
cargo test --workspace --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningsgit diff --checkAn independent review against the local feature-completeness plan and the official SliM V0.5 protocol found no remaining issues in this slice.