Honor configured default language on site creation#25
Merged
Conversation
Set `plone.default_language` from the `default_language` answer during site creation, and add a language fixture matrix (en, de) covering the registry assertion. Closes #41
Pull `plone-stubs` from GitHub as a dev/test dependency for type checking. Bump `pytest-plone` to >=1.0.0a3 and update the ruff target to py312 to match the runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_languageanswer during site creation by writing it to theplone.default_languageregistry record (fixes issue #41).tests/creation/language/{en,de}to cover the registry assertion for both locales, and lift the sharedanswers/create_sitefixtures up so they can be reused.plone-stubs(from GitHub) as a dev/test dependency to support type checking; bumppytest-ploneto>=1.0.0a3and align the ruff target with the Python 3.12 runtime.Test plan
make backend-test— 143 passed, 3 skipped