Repository navigation
Conversation
Finish published audio and transcript tracks before shutdown, and return the session delivery result before stopping the connection task. Keep reconnect cancellation and server-mode notification grace. Co-Authored-By: GPT-6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client-mode disconnect finishes the published audio and transcript tracks, requests synchronous
shutdown(), and awaitsclosed()before stopping its connection task. Delivery errors propagate to the caller, and local teardown cannot start another dial. This replaces the client close delay with the session's actual delivery result.The current consumer uses client mode. Serve mode keeps its existing notification grace; this PR makes no server-session drain guarantee and does not rewrite the accept loop.
Validation
Tested head:
10a499234599269aa194ac8995a402e8ddab4504.moq-rs>=0.6,<0.7while PyPI provides 0.5.1. The consumer builds its bindings from its pinned source; publishing is outside this change.Decisions needed
The base's registry-based GitHub workflows require unpublished moq-rs 0.6. Keep this draft pending published bindings or a separate decision about supplying source-built bindings in CI. No publication or workflow policy was chosen here; the local transport suite passes against source-built bindings.
(Written by GPT-6)