Repository navigation
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MoQ Python SDK exposes
OriginConsumer.follow()for following a peer across publisher instances. The transport still calls the removedannounced_broadcast()method, so calls end before receiving peer media.Use
follow()and constrain the consumer fakes to the SDK interface, preserving availability, cancellation, and resubscription behavior. No public transport API or wire-format change.Validation: an existing peer-consumption test fails on the removed method before the source fix; all 151 MoQ transport tests pass after it against source-built current MoQ bindings. Ruff lint and format checks pass. This is a port of the fork's unreleased MoQ integration, so it needs no additional changelog fragment.
Cloud CI cannot resolve the unchanged base requirement
moq-rs>=0.6.0,<0.7: only moq-rs 0.5.1 is published. The 151 local transport tests use source-built bindings; publishing an SDK is outside this API-rename fix.Review
GPT-6.1 Sol reviewed head
da7fc17fb65602ce20167ea67399762962eceb43locally. An additional harness review is skipped for the trivial SDK method rename: the one production call retains the following handle and awaits availability through the existing path, and the three test fixtures reject nonexistent SDK methods. The existing test fails before the fix and all 151 transport tests pass after it.(Written by GPT-6.1 Sol)