Skip to content

Django 2.0#80

Open
Ge0 wants to merge 2 commits into
klen:developfrom
Ge0:django-2.0
Open

Django 2.0#80
Ge0 wants to merge 2 commits into
klen:developfrom
Ge0:django-2.0

Conversation

@Ge0

@Ge0 Ge0 commented Dec 3, 2017

Copy link
Copy Markdown

Hello there,

Django 2.0 has just been released and the django.core.urlresolvers submodule has been replaced by django.urls. This is a breaking change and we were warned about it since Django 1.7.

The following PR submit snippets that try to import urlresolvers first (for backward compatibility before Django 2.0) then, if it fails, imports django.urls for compatibility with new Django versions.

@seenureddy

seenureddy commented Dec 20, 2017

Copy link
Copy Markdown

@Ge0 This build is failed because of --use-mirrors has been deprecated.

@Ge0

Ge0 commented Dec 20, 2017

Copy link
Copy Markdown
Author

Oh, is this project alive eventually?

We should fix the CI then. :)

@seenureddy

Copy link
Copy Markdown

I have created the ticket #82 to fix this issue.

@tomasgarzon

Copy link
Copy Markdown

Hi, I'm upgrading my project to Django 2.0, are you planning a new release fixing this soon?

@Ge0

Ge0 commented Jan 10, 2018

Copy link
Copy Markdown
Author

I think we have to find another package...

@tomasgarzon

Copy link
Copy Markdown

any suggestion?

@Ge0

Ge0 commented Jan 10, 2018

Copy link
Copy Markdown
Author

Not that I have heard recently.

Also, you can still fork the repo, fix the bug and release a django2_markdown pip package. That would help a lot of people for sure, me included!

@tomasgarzon

Copy link
Copy Markdown

Great! I'll do it!

@Ge0

Ge0 commented Jan 10, 2018

Copy link
Copy Markdown
Author

Let me know here when it's done!

@Ge0

Ge0 commented Jan 10, 2018

Copy link
Copy Markdown
Author

@tomasgarzon Sorry for the delay, but have you taken a look at https://pypi.python.org/pypi/django-markdown-app ?

@tomasgarzon

Copy link
Copy Markdown

Yes, but it doesn't have django 2.0 support, have the same problem with django.core.urlresolvers

@tomasgarzon

Copy link
Copy Markdown

Sorry, It has support but you should use pip install from git directly.

@Ge0

Ge0 commented Jan 11, 2018

Copy link
Copy Markdown
Author

Oh I see. Maybe this project is maintained compare to django_markdown.

@seenureddy

Copy link
Copy Markdown

@Ge0 https://github.com/seenureddy/django_markdown fix and merge the broken Travis. Create the PR to the repo?

@Ge0

Ge0 commented Mar 9, 2018

Copy link
Copy Markdown
Author

This repository is abandoned, not sure there is something to do.

@abdulwahid24

Copy link
Copy Markdown

@Ge0 I see you have updated the fork with Django2.0 here https://github.com/Ge0/django-markdown-gcir. I am thinking to use it because I can't go for other packages as I am working on a legacy project which is required to migrate into Django 2.0+.

I hope there won't be any issue using https://github.com/Ge0/django-markdown-gcir.
Please do let me know your thoughts.

Thanks

@Ge0

Ge0 commented Jul 5, 2019

Copy link
Copy Markdown
Author

Hey @abdulwahid24

It has been a while since I last used this package. I cannot guarantee that there won’t be any issue at this time.

You’ll might have to modify the package to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants