Conversation
R 4.6 removes the C (de-facto-)API function Rf_FindVarInFrame(). This commit updates the C implementation to add support for the new API.
Contributor
|
Hiya! I added more changes to this, found in #392, to also remove references to |
Owner
Author
|
Ah, I had overlooked the removal of … This is starting to get incredibly annoying. |
Contributor
|
Yeah, it's really annoying, especially since Luke Tierney is doing all this API cleanup without anyone else's input or review, meaning he frequently removes variables that ought to be part of the API. You might've seen my email a few days ago about something similar, how he removed R_MissingArg despite the fact that it is very necessary to have access to it. |
* remove references to R_UnboundValue In R >= 4.6, remove references to R_UnboundValue in favour of R_GetBindingType() (since R_UnboundValue will also be removed along with Rf_findVarInFrame) * avoid using R_GetBindingType(), use R_getVarEx(,,, NULL) instead * Fix promise evaluation and code style --------- Co-authored-by: Konrad Rudolph <konrad.rudolph@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R 4.6 removes the C (de-facto-)API function
Rf_FindVarInFrame(). This commit updates the C implementation to add support for the new API.