[WIP] call Tracker.OnDeletedObserver on delete wherever tracker is used

pkg/reconciler/apiserversource/controller.go

@@ -115,7 +115,11 @@ func NewController(
 
 	r.sinkResolver = resolver.NewURIResolverFromTracker(ctx, impl.Tracker)
 
-	apiServerSourceInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	apiServerSourceInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	deploymentInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
 		FilterFunc: controller.FilterController(&v1.ApiServerSource{}),

pkg/reconciler/broker/controller.go

@@ -115,7 +115,11 @@ func NewController(
 
 	brokerInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
 		FilterFunc: brokerFilter,
-		Handler:    controller.HandleAll(impl.Enqueue),
+		Handler: cache.ResourceEventHandlerFuncs{
+			AddFunc:    impl.Enqueue,
+			UpdateFunc: controller.PassNew(impl.Enqueue),
+			DeleteFunc: impl.Tracker.OnDeletedObserver,
+		},
 	})
 
 	// When the endpoints in our multi-tenant filter/ingress change, do a global resync.

pkg/reconciler/broker/trigger/controller.go

@@ -95,7 +95,11 @@ func NewController(
 
 	triggerInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
 		FilterFunc: filterTriggers(featureStore, r.brokerLister),
-		Handler:    controller.HandleAll(impl.Enqueue),
+		Handler: cache.ResourceEventHandlerFuncs{
+			AddFunc:    impl.Enqueue,
+			UpdateFunc: controller.PassNew(impl.Enqueue),
+			DeleteFunc: impl.Tracker.OnDeletedObserver,
+		},
 	})
 
 	// Filter Brokers and enqueue associated Triggers

pkg/reconciler/channel/controller.go

@@ -19,6 +19,7 @@ package channel
 import (
 	"context"
 
+	"k8s.io/client-go/tools/cache"
 	messagingv1 "knative.dev/eventing/pkg/apis/messaging/v1"
 	"knative.dev/eventing/pkg/auth"
 
@@ -73,7 +74,11 @@ func NewController(
 		impl.GlobalResync(channelInformer.Informer())
 	}
 
-	channelInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	channelInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	channelGK := messagingv1.SchemeGroupVersion.WithKind("Channel").GroupKind()
 

pkg/reconciler/eventpolicy/controller.go

@@ -19,6 +19,7 @@ package eventpolicy
 import (
 	"context"
 
+	"k8s.io/client-go/tools/cache"
 	"knative.dev/eventing/pkg/apis/feature"
 	"knative.dev/pkg/logging"
 
@@ -61,7 +62,11 @@ func NewController(
 	}
 
 	// Set up event handlers
-	eventPolicyInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	eventPolicyInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	return impl
 }

pkg/reconciler/eventtype/controller.go

@@ -19,6 +19,7 @@ package eventtype
 import (
 	"context"
 
+	"k8s.io/client-go/tools/cache"
 	"knative.dev/eventing/pkg/resolver"
 	"knative.dev/pkg/configmap"
 	"knative.dev/pkg/controller"
@@ -38,7 +39,11 @@ func NewController(
 	r := &Reconciler{}
 	impl := eventtypereconciler.NewImpl(ctx, r)
 
-	eventTypeInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	eventTypeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	// Tracker is used to notify us that a EventType's Broker has changed so that
 	// we can reconcile.

pkg/reconciler/inmemorychannel/controller/controller.go

@@ -111,7 +111,11 @@ func NewController(
 	})
 	r.uriResolver = resolver.NewURIResolverFromTracker(ctx, impl.Tracker)
 
-	inmemorychannelInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	inmemorychannelInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	// Set up watches for dispatcher resources we care about, since any changes to these
 	// resources will affect our Channels. So, set up a watch here, that will cause

pkg/reconciler/parallel/controller.go

@@ -71,7 +71,11 @@ func NewController(
 	})
 
 	r.channelableTracker = duck.NewListableTrackerFromTracker(ctx, channelable.Get, impl.Tracker)
-	parallelInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	parallelInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	// Register handler for Subscriptions that are owned by Parallel, so that
 	// we get notified if they change.

pkg/reconciler/pingsource/controller.go

@@ -99,7 +99,11 @@ func NewController(
 
 	r.sinkResolver = resolver.NewURIResolver(ctx, cmw, impl.Tracker)
 
-	pingSourceInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	pingSourceInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	// Tracker is used to notify us that the pingsource-mt-adapter Deployment has changed so that
 	// we can reconcile PingSources that depend on it

pkg/reconciler/sequence/controller.go

@@ -77,7 +77,11 @@ func NewController(
 	}
 
 	r.channelableTracker = duck.NewListableTrackerFromTracker(ctx, channelable.Get, impl.Tracker)
-	sequenceInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	sequenceInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	// Register handler for Subscriptions that are owned by Sequence, so that
 	// we get notified if they change.

pkg/reconciler/sinkbinding/controller.go

@@ -129,7 +129,11 @@ func NewController(
 		impl.GlobalResync(sbInformer.Informer())
 	}
 
-	sbInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	sbInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 	namespaceInformer.Informer().AddEventHandler(controller.HandleAll(func(obj interface{}) {
 		ns, err := kmeta.DeletionHandlingAccessor(obj)
 		if err != nil {

pkg/reconciler/subscription/controller.go

@@ -79,7 +79,11 @@ func NewController(
 		impl.GlobalResync(subscriptionInformer.Informer())
 	}
 
-	subscriptionInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
+	subscriptionInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
+		AddFunc:    impl.Enqueue,
+		UpdateFunc: controller.PassNew(impl.Enqueue),
+		DeleteFunc: impl.Tracker.OnDeletedObserver,
+	})
 
 	// Trackers used to notify us when the resources Subscription depends on change, so that the
 	// Subscription needs to reconcile again.