Skip to content

Comments

Folder refactoring#16

Open
igauravsehrawat wants to merge 10 commits intoknaxus:folder-refactoringfrom
igauravsehrawat:folder-refactoring
Open

Folder refactoring#16
igauravsehrawat wants to merge 10 commits intoknaxus:folder-refactoringfrom
igauravsehrawat:folder-refactoring

Conversation

@igauravsehrawat
Copy link
Contributor

Added a service folder.
I have a doubt on where to put it. I put it, closest to its use.

@ashokdey
Copy link
Member

ashokdey commented Sep 13, 2018

@igauravsehrawat : services folder has to be in the root of app folder. Please revise it.
Also inside app/helpers/sendResponse.js can you modify line 12 to send success for HTTP code 3XX?

Thanks!

@igauravsehrawat
Copy link
Contributor Author

services folder is outside, should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants