fix: overlapping edits when transpiling with stripped types.#86
Merged
knightedcodemonkey merged 2 commits intomainfrom Mar 16, 2026
Merged
fix: overlapping edits when transpiling with stripped types.#86knightedcodemonkey merged 2 commits intomainfrom
knightedcodemonkey merged 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 88.51% 88.21% -0.31%
==========================================
Files 25 25
Lines 1986 2019 +33
Branches 540 547 +7
==========================================
+ Hits 1758 1781 +23
- Misses 72 77 +5
- Partials 156 161 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a more robust TypeScript “strip” pipeline by iterating TS-syntax removal until stable, enabling removal of chained casts around JSX output.
Changes:
- Add multi-pass TypeScript stripping (
stripTypeScriptSyntax) to handle nested/chained TS wrapper nodes. - Refactor
transpileJsxSourceto perform JSX compilation first, then run TS stripping on the generated code whentypescript: 'strip'. - Add a regression test for chained TS casts around JSX expressions; bump package version to 1.9.2.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/transpile.test.ts | Adds coverage for chained as casts around a JSX expression in strip mode. |
| src/transpile.ts | Introduces iterative TS stripping and refactors JSX/TS strip flow. |
| package.json | Bumps package version to 1.9.2. |
| package-lock.json | Updates lockfile version fields to match 1.9.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.