Skip to content

refactor: replace npm glob with node fs glob.#53

Merged
knightedcodemonkey merged 2 commits intomainfrom
bananas
Mar 7, 2026
Merged

refactor: replace npm glob with node fs glob.#53
knightedcodemonkey merged 2 commits intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 7, 2026 20:26
@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.39%. Comparing base (30572ae) to head (7dd51c6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   93.40%   93.39%   -0.01%     
==========================================
  Files          26       26              
  Lines        5197     5196       -1     
  Branches     1148     1149       +1     
==========================================
- Hits         4854     4853       -1     
  Misses        305      305              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the CLI’s file pattern expansion to use Node’s built-in node:fs/promises.glob instead of the glob npm dependency, with added CLI tests to validate key glob behaviors.

Changes:

  • Replace glob (npm) usage in src/cli.ts with node:fs/promises.glob and adjust ignore handling.
  • Add CLI tests for directory exclusion in glob expansion and for README-style glob patterns in the pre-tsc “globals-only” flow.
  • Remove glob from runtime dependencies and bump package version to 1.5.2.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
test/cli.ts Adds coverage for directory handling in glob expansion and a README-like glob pattern workflow.
src/cli.ts Switches file expansion to Node’s built-in glob and implements directory filtering via stat().
package.json Bumps version and removes glob from dependencies.
package-lock.json Updates lockfile to reflect dependency changes and version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 2471371 into main Mar 7, 2026
10 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch March 7, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants