refactor: replace npm glob with node fs glob.#53
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 93.40% 93.39% -0.01%
==========================================
Files 26 26
Lines 5197 5196 -1
Branches 1148 1149 +1
==========================================
- Hits 4854 4853 -1
Misses 305 305
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Refactors the CLI’s file pattern expansion to use Node’s built-in node:fs/promises.glob instead of the glob npm dependency, with added CLI tests to validate key glob behaviors.
Changes:
- Replace
glob(npm) usage insrc/cli.tswithnode:fs/promises.globand adjust ignore handling. - Add CLI tests for directory exclusion in glob expansion and for README-style glob patterns in the pre-
tsc“globals-only” flow. - Remove
globfrom runtime dependencies and bump package version to1.5.2.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/cli.ts | Adds coverage for directory handling in glob expansion and a README-like glob pattern workflow. |
| src/cli.ts | Switches file expansion to Node’s built-in glob and implements directory filtering via stat(). |
| package.json | Bumps version and removes glob from dependencies. |
| package-lock.json | Updates lockfile to reflect dependency changes and version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.