fix: recognize flow.google.com and surface upload bridge errors - #11
Open
ballz921 wants to merge 1 commit into
Open
fix: recognize flow.google.com and surface upload bridge errors#11ballz921 wants to merge 1 commit into
ballz921 wants to merge 1 commit into
Conversation
santoshray02
approved these changes
Sep 8, 2026
santoshray02
left a comment
Contributor
There was a problem hiding this comment.
Reproduced both errors on a live deployment (backend 2.0.5 on a headless VPS, extension in a remote Chrome) on 2026-09-08:
CAPTCHA_FAILED: Cannot access contents of url "https://flow.google.com/"with a flow.google.com tab openretryTabs is not definedon the fresh-tab path with no Flow tab open
This PR's manifest and background.js changes are exactly what fixes those two failures; I had hand-patched the same lines locally before finding this and reverted in favour of it. The isFlowUrl() predicate is cleaner than the old regex.
Two notes for whoever merges:
- As the description says, this does not make generation work on flow.google.com. #10 documents that the new site uses cookie auth, no
grecaptcha, and abatchexecuteRPC instead of theaisandbox-paREST call. Worth keeping #10 open or re-linking it, since it is closed. https://labs.google/fx/tools/flowstill serves the full app with no server-side redirect as of today, so with this PR the legacy path remains the working one when a labs.google tab is in the foreground.
Approving on the strength of the reproduced fix; the #10 port is separate work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #10 — partial remediation, not a claim that the new Flow generation API works end to end.
https://flow.google.com/*to the extension's host permissions, content script matches, and web-accessible resource matches, while retaining legacy Flow support.createdTabfrom the fresh-tab path instead of the undefinedretryTabs[0].Unknown. Do not serialize response objects into logs.Observed failure
An installation at
206285arecorded these extension errors:The Python upload path reduced these errors to
Image upload failed: Unknown, then the local API returned HTTP 500. That local 500 is not proof that Google's upload endpoint returned 500.Validation
From
flow-agent/:Deliberately out of scope
No cookie/batchexecute migration, authentication changes, CAPTCHA disabling/bypass, Origin/Referer changes, REST endpoint changes, or callback-secret handling changes. New-site token capture, CAPTCHA execution and live upload/generation remain unverified and may require follow-up work described in #10. This PR does not close that broader issue.