Skip to content

chore: stop CodeRabbit from reporting the TPL checklist item count - #2930

Merged
kompiro merged 1 commit into
mainfrom
chore/coderabbit-no-tpl-checklist-count
Sep 27, 2026
Merged

kompiro merged 1 commit into
mainfrom
chore/coderabbit-no-tpl-checklist-count

Conversation

@kompiro

@kompiro kompiro commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

The docs/test-perspectives/** path instruction told CodeRabbit to report "a checklist outside 3-5 items". On #2908 it asked to cut TPL-2593's nine items down to 3-5, where each item is a distinct, observable check and merging them would only produce compound items that are harder to answer yes/no. The maintainer decided to keep the nine.

The 3-5 range in docs/test-perspectives/README.md / TEMPLATE.md stays as an authoring guideline; this PR only stops CodeRabbit from treating the count as a defect. The other half of the same bullet (an item phrased as an intention instead of an observable condition) is kept.

Test plan

  • Config-only; pre-push hook passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated checklist review guidance: checklist items must still be phrased as observable yes/no conditions, but counts outside the suggested range are no longer flagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: kompiro/karasu/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 4393500f-22ac-4b1d-982f-961870468d2f

📥 Commits

Reviewing files that changed from the base of the PR and between eb44043 and f1a3cca.

📒 Files selected for processing (1)
  • .coderabbit.yaml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.


📝 Walkthrough

Walkthrough

The TPL checklist guidance no longer flags counts outside three to five items. It retains the criterion that checklist items must describe observable yes/no conditions.

Changes

TPL checklist guidance

Layer / File(s) Summary
Checklist reporting criteria
.coderabbit.yaml
The guidance removes checklist item count as a reporting criterion. It retains the requirement for observable yes/no conditions and clarifies that more than five distinct, observable items are not a defect.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f1a3c

No actionable merge risk remains in this guidance change; it is ready to merge subject to normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title accurately describes the configuration change, but it does not include the required package scope in the Conventional Commits format. Add the appropriate scope, such as chore(docs-test-perspectives): stop CodeRabbit from reporting the TPL checklist item count, and keep the subject in imperative mood without a trailing period.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@kompiro
kompiro marked this pull request as ready for review September 27, 2026 06:25
@kompiro
kompiro merged commit 73eac7a into main Sep 27, 2026
7 checks passed
@kompiro
kompiro deleted the chore/coderabbit-no-tpl-checklist-count branch September 27, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant