fix(form-field): sync heights inside fieldset (#DS-5370) - #1841
Conversation
|
Visit the preview URL for this PR (updated for commit 5207df4): https://koobiq-next--prs-1841-2g4e9k9r.web.app (expires Sat, 08 Aug 2026 12:37:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
93be2a8 to
95c91b3
Compare
95c91b3 to
5207df4
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a 1px “seam” regression in kbq-fieldset groups by ensuring kbq-form-field and adjacent controls (e.g., outline buttons) resolve to the same pixel-snapped height after resize/subpixel recalculation, and adds an E2E assertion that specifically exercises fractional device pixel ratios.
Changes:
- Force
kbq-form-fieldheight withinkbq-fieldsetto use the single height token and propagate that height down to the form-field container. - Add a Playwright E2E check that compares form-field container and button bounding boxes at fractional
deviceScaleFactorvalues (1.5x, 2.5x). - Surface the new “fieldset + button” example in the form-field dev examples page.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/form-field/fieldset.scss | Forces token-based height synchronization for form-fields inside fieldsets and propagates 100% height to inner content/container. |
| packages/components/form-field/e2e.playwright-spec.ts | Adds fractional-DPR coverage to catch border seam regressions that don’t reproduce at 1x DPR. |
| packages/components-dev/form-field/module.ts | Includes and renders the new fieldset-with-button docs example in the dev examples view. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.