Skip to content

fix(form-field): sync heights inside fieldset (#DS-5370) - #1841

Merged
NikGurev merged 1 commit into
mainfrom
bugfix/DS-5370
Aug 6, 2026
Merged

fix(form-field): sync heights inside fieldset (#DS-5370)#1841
NikGurev merged 1 commit into
mainfrom
bugfix/DS-5370

Conversation

@NikGurev

@NikGurev NikGurev commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@NikGurev NikGurev self-assigned this Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 5207df4):

https://koobiq-next--prs-1841-2g4e9k9r.web.app

(expires Sat, 08 Aug 2026 12:37:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev

NikGurev commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

✅ Snapshots updated!

@NikGurev
NikGurev marked this pull request as ready for review August 5, 2026 12:29
@NikGurev
NikGurev requested a review from lskramarov as a code owner August 5, 2026 12:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a 1px “seam” regression in kbq-fieldset groups by ensuring kbq-form-field and adjacent controls (e.g., outline buttons) resolve to the same pixel-snapped height after resize/subpixel recalculation, and adds an E2E assertion that specifically exercises fractional device pixel ratios.

Changes:

  • Force kbq-form-field height within kbq-fieldset to use the single height token and propagate that height down to the form-field container.
  • Add a Playwright E2E check that compares form-field container and button bounding boxes at fractional deviceScaleFactor values (1.5x, 2.5x).
  • Surface the new “fieldset + button” example in the form-field dev examples page.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/components/form-field/fieldset.scss Forces token-based height synchronization for form-fields inside fieldsets and propagates 100% height to inner content/container.
packages/components/form-field/e2e.playwright-spec.ts Adds fractional-DPR coverage to catch border seam regressions that don’t reproduce at 1x DPR.
packages/components-dev/form-field/module.ts Includes and renders the new fieldset-with-button docs example in the dev examples view.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NikGurev
NikGurev merged commit a79d598 into main Aug 6, 2026
12 checks passed
@NikGurev
NikGurev deleted the bugfix/DS-5370 branch August 6, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants