fix(tags): unfocus input on TAB keypress (#DS-5399) - #1846
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the KbqTagInput keyboard handling so that pressing TAB with an empty input doesn’t get blocked by the tag separator logic, allowing normal focus traversal (blur/unfocus) behavior in forms.
Changes:
- Update
KbqTagInput.onKeydownto avoid callingpreventDefault()for TAB when the input is empty. - Add a unit test intended to ensure TAB doesn’t have its default prevented in that scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/components/tags/tag-input.ts | Skips preventDefault() for TAB separator when input is empty to allow focus to move. |
| packages/components/tags/tag-input.spec.ts | Adds a test for TAB + empty input behavior (currently needs adjustment to be effective). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 72b9ca4): https://koobiq-next--prs-1846-mi3z3965.web.app (expires Sat, 08 Aug 2026 10:17:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1844