Skip to content

fix(tags): unfocus input on TAB keypress (#DS-5399) - #1846

Merged
artembelik merged 1 commit into
19.xfrom
fix/DS-5399-v19
Aug 5, 2026
Merged

fix(tags): unfocus input on TAB keypress (#DS-5399)#1846
artembelik merged 1 commit into
19.xfrom
fix/DS-5399-v19

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

@artembelik artembelik self-assigned this Aug 5, 2026
Copilot AI lite review requested due to automatic review settings August 5, 2026 10:12
@artembelik
artembelik requested a review from NikGurev as a code owner August 5, 2026 10:12
@artembelik artembelik added bug Something isn't working 19.x labels Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the KbqTagInput keyboard handling so that pressing TAB with an empty input doesn’t get blocked by the tag separator logic, allowing normal focus traversal (blur/unfocus) behavior in forms.

Changes:

  • Update KbqTagInput.onKeydown to avoid calling preventDefault() for TAB when the input is empty.
  • Add a unit test intended to ensure TAB doesn’t have its default prevented in that scenario.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/components/tags/tag-input.ts Skips preventDefault() for TAB separator when input is empty to allow focus to move.
packages/components/tags/tag-input.spec.ts Adds a test for TAB + empty input behavior (currently needs adjustment to be effective).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/tags/tag-input.spec.ts
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 72b9ca4):

https://koobiq-next--prs-1846-mi3z3965.web.app

(expires Sat, 08 Aug 2026 10:17:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik
artembelik merged commit ee2dde7 into 19.x Aug 5, 2026
10 of 11 checks passed
@artembelik
artembelik deleted the fix/DS-5399-v19 branch August 5, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

19.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants