fix(components)!: unresolvable peerDependencies break npm install (#DS-4889) - #1853
Draft
lskramarov wants to merge 2 commits into
Draft
fix(components)!: unresolvable peerDependencies break npm install (#DS-4889)#1853lskramarov wants to merge 2 commits into
lskramarov wants to merge 2 commits into
Conversation
…S-4889)
Consumers hit "ERESOLVE unable to resolve dependency tree" on install.
- @koobiq/icons peer was a major behind what `ng add` injects (^11.1.3 vs
^12.1.1), which breaks a plain Angular 20 app following the install guide
- @angular/common and platform-browser were imported but never declared,
leaving npm free to mix Angular majors
- the packager assigned a bare version, exact-pinning components and the date
adapters to each other in a cycle; it now substitutes, so `^{{VERSION}}`
works, and it fails the build if a placeholder survives
- rxjs, marked, overlayscrollbars and @koobiq/date-adapter ship as external
imports and are now declared; both adapters become optional peers, since
nothing in the published bundles imports them
- `ng add` now installs @angular/animations, a mandatory peer that the
schematic never added
Adds `check-peer-deps` (linters) and `check-npm-resolution` (build + publish),
which resolves the built tarballs with npm. Yarn's node-modules linker
downgrades these conflicts to warnings, which is why CI never caught them.
BREAKING CHANGE: peerDependencies changed in every published package.
@koobiq/angular-luxon-adapter and @koobiq/angular-moment-adapter are now
optional peers and are no longer installed automatically — add the one you use
explicitly. @angular/cdk, @angular/animations and overlayscrollbars must be
present in the consuming application.
|
Visit the preview URL for this PR (updated for commit c49e129): https://koobiq-next--prs-1853-3z9vq04g.web.app (expires Sat, 08 Aug 2026 17:51:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.