Skip to content

fix(list,select): disabled and selected (#DS-5375) - #1855

Open
artembelik wants to merge 2 commits into
mainfrom
fix/DS-5375
Open

fix(list,select): disabled and selected (#DS-5375)#1855
artembelik wants to merge 2 commits into
mainfrom
fix/DS-5375

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

No description provided.

@artembelik artembelik self-assigned this Aug 6, 2026
Copilot AI lite review requested due to automatic review settings August 6, 2026 14:13
@artembelik
artembelik requested a review from lskramarov as a code owner August 6, 2026 14:13
@artembelik artembelik added the bug Something isn't working label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 1d05ef7):

https://koobiq-next--prs-1855-ljjt6kvj.web.app

(expires Sun, 09 Aug 2026 14:16:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the “disabled + selected” visual state for kbq-list and kbq-select options, and adds new E2E fixtures + Playwright visual tests to lock in the expected rendering.

Changes:

  • Add theme rules so options that are both kbq-selected and kbq-disabled keep the “selected” background (while retaining disabled text styling).
  • Introduce new E2E demo components for list/select selection state scenarios.
  • Add Playwright screenshot coverage for the new fixtures and register them in the E2E routes.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/e2e/routes.ts Registers new list/select E2E fixtures so they can be navigated to in Playwright (/E2eListSelectionState, /E2eSelectSelectionState).
packages/components/select/e2e.ts Adds E2eSelectSelectionState fixture demonstrating selected + disabled option rendering in select.
packages/components/select/e2e.playwright-spec.ts Adds a visual regression test for the select selected+disabled scenario.
packages/components/list/e2e.ts Adds E2eListSelectionState fixture demonstrating selected + disabled option rendering in list selection.
packages/components/list/e2e.playwright-spec.ts Adds a visual regression test for the list selected+disabled scenario.
packages/components/list/_list-theme.scss Applies selected-background tokens when list options are both selected and disabled (single + multiple modes).
packages/components/core/option/_option-theme.scss Applies selected-background tokens when core options are both selected and disabled (single + multiple modes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/list/e2e.ts
Comment thread packages/components/list/e2e.playwright-spec.ts
Comment thread packages/components/select/e2e.playwright-spec.ts
@artembelik

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

✅ Snapshots updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants