fix(list,select): disabled and selected (#DS-5375) - #1855
Conversation
|
Visit the preview URL for this PR (updated for commit 1d05ef7): https://koobiq-next--prs-1855-ljjt6kvj.web.app (expires Sun, 09 Aug 2026 14:16:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses the “disabled + selected” visual state for kbq-list and kbq-select options, and adds new E2E fixtures + Playwright visual tests to lock in the expected rendering.
Changes:
- Add theme rules so options that are both
kbq-selectedandkbq-disabledkeep the “selected” background (while retaining disabled text styling). - Introduce new E2E demo components for list/select selection state scenarios.
- Add Playwright screenshot coverage for the new fixtures and register them in the E2E routes.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/e2e/routes.ts | Registers new list/select E2E fixtures so they can be navigated to in Playwright (/E2eListSelectionState, /E2eSelectSelectionState). |
| packages/components/select/e2e.ts | Adds E2eSelectSelectionState fixture demonstrating selected + disabled option rendering in select. |
| packages/components/select/e2e.playwright-spec.ts | Adds a visual regression test for the select selected+disabled scenario. |
| packages/components/list/e2e.ts | Adds E2eListSelectionState fixture demonstrating selected + disabled option rendering in list selection. |
| packages/components/list/e2e.playwright-spec.ts | Adds a visual regression test for the list selected+disabled scenario. |
| packages/components/list/_list-theme.scss | Applies selected-background tokens when list options are both selected and disabled (single + multiple modes). |
| packages/components/core/option/_option-theme.scss | Applies selected-background tokens when core options are both selected and disabled (single + multiple modes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
No description provided.