fix(spacing): fix zero-value padding utility classes (DS-5389) - #442
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe spacing module corrects four zero-value padding utilities. Each utility now sets its intended logical padding property instead of ChangesSpacing utility corrections
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit 5c78763): https://react-koobiq-next--prs-442-vs5s2rd9.web.app (expires Sat, 08 Aug 2026 07:48:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
This PR fixes the zero-value padding utility classes in the layout spacing CSS module so they apply padding to the correct logical sides instead of mistakenly affecting margins.
Changes:
- Update
.pbs_0,.pie_0,.pbe_0, and.pis_0to use the correspondingpadding-*logical properties. - Remove previously incorrect
*_autopadding-side utilities that were settingmargin-block-start.
Suppressed comments (3)
packages/components/src/components/layout/spacing/spacing.module.css:305
SpacingGapincludesautoand is used forpieinspacing.ts(s[pie_${pieVal}]), butpie_autois no longer defined in this CSS module. If a consumer setspie="auto"it will now silently do nothing. Align the TS API and CSS classes by either disallowingautofor padding props or reintroducing a safepie_automapping.
/* Padding Inline End */
.pie_0 {
padding-inline-end: 0;
}
packages/components/src/components/layout/spacing/spacing.module.css:362
pbepadding props can still takeautoviaSpacingGap, but there is no longer apbe_autoclass in this CSS module. That makespbe="auto"a runtime no-op (undefined CSS module key). Consider splitting margin/padding gap unions or remappingautofor padding.
/* Padding Block End */
.pbe_0 {
padding-block-end: 0;
}
packages/components/src/components/layout/spacing/spacing.module.css:419
pispadding props can still receiveautothroughSpacingGap, butpis_autois no longer defined. Ifpis="auto"is passed,s[pis_${pisVal}]will resolve to undefined and apply no padding. Align allowed values between TS and CSS (separate padding union or remapauto).
/* Padding Inline Start */
.pis_0 {
padding-inline-start: 0;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit