Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { userEvent } from '@testing-library/user-event';
import { afterAll, beforeAll, describe, expect, it, vi } from 'vitest';

import { Form } from '../Form';
import { Popover } from '../Popover';
import { Provider } from '../Provider';
import { Tree } from '../Tree';

Expand Down Expand Up @@ -490,6 +491,18 @@ describe('TreeSelect', () => {
});

describe('clear button', () => {
it('should not throw on render in a popover', () => {
expect(() => {
render(
<Popover defaultOpen>
<Popover.Body>
<TreeSelectFixture isClearable />
</Popover.Body>
</Popover>
);
}).not.toThrow();
});

it('should be visible only when a value is selected', () => {
const { rerender } = renderTreeSelect({ value: null, isClearable: true });

Expand Down
79 changes: 48 additions & 31 deletions packages/components/src/components/TreeSelect/TreeSelect.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@ import {
} from '@koobiq/react-core';
import { IconChevronDownS16 } from '@koobiq/react-icons';
import {
ButtonContext,
CollectionBuilder,
Collection,
DEFAULT_SLOT,
FieldErrorContext,
Provider,
composeRenderProps,
useTreeSelect,
useTreeSelectState,
Expand Down Expand Up @@ -408,38 +411,52 @@ export function TreeSelectInner<
);

return (
<FormField {...rootProps}>
<FormField.Label {...labelProps} />
<div className={s.body}>
<FormField.ControlGroup {...groupProps}>
<FormField.Select {...controlProps}>
{state.selectedItems.length ? renderValue : undefined}
</FormField.Select>
</FormField.ControlGroup>
<FieldErrorContext.Provider value={validation}>
<FormField.Error {...errorProps} />
</FieldErrorContext.Provider>
<FormField.Caption {...captionProps} />
</div>
<PopoverInner {...popoverProps}>
<div className={s.content}>
{isSearchable && (
<>
<SearchInput {...searchInputProps} />
<Divider disablePaddings />
</>
)}
<TreeInner
props={innerTreeProps}
treeRef={treeRef}
state={filteredTreeState}
/>
<DropdownFooter {...slotProps?.dropdownFooter}>
{dropdownFooter}
</DropdownFooter>
<Provider
values={[
[
ButtonContext,
{
slots: {
[DEFAULT_SLOT]: {},
'clear-button': {},
},
},
],
]}
>
<FormField {...rootProps}>
<FormField.Label {...labelProps} />
<div className={s.body}>
<FormField.ControlGroup {...groupProps}>
<FormField.Select {...controlProps}>
{state.selectedItems.length ? renderValue : undefined}
</FormField.Select>
</FormField.ControlGroup>
<FieldErrorContext.Provider value={validation}>
<FormField.Error {...errorProps} />
</FieldErrorContext.Provider>
<FormField.Caption {...captionProps} />
</div>
</PopoverInner>
</FormField>
<PopoverInner {...popoverProps}>
<div className={s.content}>
{isSearchable && (
<>
<SearchInput {...searchInputProps} />
<Divider disablePaddings />
</>
)}
<TreeInner
props={innerTreeProps}
treeRef={treeRef}
state={filteredTreeState}
/>
<DropdownFooter {...slotProps?.dropdownFooter}>
{dropdownFooter}
</DropdownFooter>
</div>
</PopoverInner>
</FormField>
</Provider>
);
}

Expand Down
Loading