feat: explicit :dir overrides heading target tag - #10
Closed
kpassapk wants to merge 3 commits into
Closed
Conversation
The babel advice consed its resolved target onto params, so it won over any :dir on the block itself, and multi-tag headings prompted for a target even when the block already had one. Skip resolution entirely when a :dir is present in the override params or the block's resolved params (block, #+header: line, or header-args property); :dir nil opts a block out of injection. Also pass executor-type through to the advised function instead of dropping it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The babel advice consed its resolved target onto params, so it won over any :dir on the block itself, and multi-tag headings prompted for a target even when the block already had one. Skip resolution entirely when a :dir is present in the override params or the block's resolved params (block, #+header: line, or header-args property); :dir nil opts a block out of injection.
Also pass executor-type through to the advised function instead of dropping it.