Upgrade Go to 1.26.3 and update dependencies across functions#1251
Merged
Conversation
✅ Deploy Preview for krm-function-catalog canceled.
|
mozesl-nokia
approved these changes
May 21, 2026
43dfbe4 to
30523c3
Compare
Contributor
Author
|
This needs to be rebased on top #1245 for the documentation fix. |
- Bumped Go version to 1.26.3 - Updated module dependencies - Verified build passes for all modules Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
30523c3 to
603decc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Go toolchain version and aligns a broad set of Go module dependencies across the catalog functions/scripts to reduce cross-repo/workspace version conflicts, including the kustomize/k8s dependency stack and the mergo module path change.
Changes:
- Bump
godirective across many modules to1.26.3and refresh dependency versions (kustomize, k8s.io, kpt, x/*, etc.). - Migrate
github.com/imdario/mergoimport usage todario.cat/mergowhere applicable. - Update several kyaml framework-based functions to use the newer
ResourceList.Resultspatterns and refreshed dependency graph.
Reviewed changes
Copilot reviewed 27 out of 49 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2etest/go.mod | Bumps Go version and refreshes e2e test module dependencies (kpt/k8s/kustomize stack). |
| scripts/generate_docs/main_test.go | Formatting-only alignment in tests. |
| scripts/generate_docs/go.mod | Bumps Go version and updates golang.org/x/text indirect dependency. |
| scripts/generate_docs/go.sum | Updates checksums for refreshed dependencies. |
| scripts/generate_docs/generate_docs.go | Formatting cleanup; minor whitespace fix in CutPrefix usage. |
| functions/go/upsert-resource/go.mod | Bumps Go version and updates kyaml/testify and related indirect deps. |
| functions/go/upsert-resource/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/starlark/go.mod | Bumps Go version and updates starlark/k8s/kustomize/kpt dependencies. |
| functions/go/sleep/go.mod | Bumps Go version and updates kyaml to v0.21.1. |
| functions/go/sleep/go.sum | Updates checksums for kyaml v0.21.1. |
| functions/go/set-namespace/transformer/namespace.go | Refactors namespace pointer handling (currently introduces a compile error). |
| functions/go/set-namespace/go.mod | Bumps Go version and updates k8s/kustomize/kpt dependency set. |
| functions/go/set-labels/go.mod | Bumps Go version and updates k8s/kustomize/kpt dependency set. |
| functions/go/set-labels/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/set-image/go.mod | Bumps Go version and updates k8s/kustomize/kpt dependency set. |
| functions/go/set-image/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/set-enforcement-action/main.go | Updates kyaml framework result handling APIs/structures. |
| functions/go/set-enforcement-action/go.mod | Bumps Go version and updates kyaml/testify and related indirect deps. |
| functions/go/set-annotations/go.mod | Bumps Go version (dependency alignment for this function’s module). |
| functions/go/search-replace/main.go | Updates kyaml framework result handling APIs/structures. |
| functions/go/search-replace/go.mod | Bumps Go version and updates kyaml/doublestar/testify and related deps. |
| functions/go/render-helm-chart/third_party/sigs.k8s.io/kustomize/api/builtins/HelmChartInflationGenerator.go | Switches mergo import path to dario.cat/mergo. |
| functions/go/render-helm-chart/go.mod | Bumps Go version; updates mergo module path and dependency versions. |
| functions/go/remove-local-config-resources/main.go | Updates kyaml framework result handling APIs/structures. |
| functions/go/remove-local-config-resources/main_test.go | Updates tests to match new results return types. |
| functions/go/remove-local-config-resources/go.mod | Bumps Go version and updates kyaml/testify and related indirect deps. |
| functions/go/no-op/go.mod | Bumps Go version and updates k8s/kustomize/kpt dependency set. |
| functions/go/no-op/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/list-setters/go.mod | Bumps Go version and updates kpt/kustomize dependency versions. |
| functions/go/kubeconform/go.mod | Bumps Go version and updates cobra/kpt/kustomize dependency versions. |
| functions/go/kubeconform/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/generate-kpt-pkg-docs/go.mod | Bumps Go version; updates some deps but leaves kpt/kyaml versions inconsistent with PR description. |
| functions/go/generate-kpt-pkg-docs/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/delete-annotations/go.mod | Bumps Go version and updates k8s/kustomize/kpt dependency set. |
| functions/go/delete-annotations/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/apply-replacements/go.mod | Bumps Go version and updates kustomize api/kyaml dependency versions. |
| functions/go/apply-replacements/go.sum | Updates checksums for refreshed dependencies. |
| functions/go/annotate-apply-time-mutations/go.mod | Bumps Go version and updates apimachinery/kyaml dependency versions. |
| functions/go/annotate-apply-time-mutations/go.sum | Updates checksums for refreshed dependencies. |
| documentation/go.mod | Updates doc toolchain dependency (docsy). |
| documentation/go.sum | Updates checksums for refreshed doc dependencies. |
Comments suppressed due to low confidence (3)
functions/go/set-namespace/transformer/namespace.go:240
new(NestedStringOrDie(...))is invalid Go syntax becausenewexpects a type, not a function call result. This will not compile. Use a local variable and take its address, or allocatenew(string)and assign the nested value into it before calling the visitor.
functions/go/set-namespace/transformer/namespace.go:265new(o.GetNamespace())is invalid Go syntax becausenewexpects a type, not a value/expression. This will not compile. Allocate astringand assign the namespace, or revert to the previousnamespace := o.GetNamespace(); nsPtr := &namespacepattern.
functions/go/generate-kpt-pkg-docs/go.mod:11- PR description says kpt is being upgraded to v1.0.0-beta.63 and kustomize/kyaml to v0.21.1, but this module still pins
github.com/kptdev/kpt v1.0.0-beta.62.1andsigs.k8s.io/kustomize/kyaml v0.20.1. If the goal is to align versions to avoid workspace conflicts, please update these to match the rest of the repo (or clarify in the PR description why this module must remain on older versions).
require (
github.com/kptdev/kpt v1.0.0-beta.62.1
github.com/kptdev/krm-functions-catalog/functions/go/list-setters v0.0.0-20251006065330-cad54762e815
github.com/olekukonko/tablewriter v0.0.5
github.com/stretchr/testify v1.11.1
sigs.k8s.io/kustomize/kyaml v0.20.1
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
3341d7f to
3771db3
Compare
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
3771db3 to
08128cb
Compare
liamfallon
reviewed
May 25, 2026
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
liamfallon
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This aligns the catalog dependency versions to the latest, preparing for a unified workspace where all repos can build together without version conflicts.
Key dependency upgrades:
Testing
AI usage disclosure