Handle empty input gracefully#756
Merged
Merged
Conversation
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Go KRM Functions SDK to treat zero-length (or whitespace-only) input as an empty ResourceList, avoiding a parsing failure and adding regression tests around empty input/serialization.
Changes:
- Update
ParseResourceListto return an emptyResourceListfor empty/whitespace input. - Harden empty
ResourceListYAML serialization by avoiding nil dereferences aroundFunctionConfig. - Add unit tests for
Run([]byte{}),ParseResourceList([]byte{}), andToYAML()on an emptyResourceList.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/fn/run_test.go | Adds a regression test asserting Run succeeds with empty input and returns a minimal ResourceList YAML. |
| go/fn/resourcelist.go | Treats empty input as an empty ResourceList; updates parse error message; avoids nil deref when serializing functionConfig. |
| go/fn/resourcelist_test.go | Adds tests for parsing zero bytes and serializing an empty ResourceList without panicking. |
| go/fn/object.go | Makes KubeObject.IsEmpty() safe to call on a nil receiver / nil internal object. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
kispaljr
approved these changes
May 22, 2026
liamfallon
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, running a ResourceListProcessor with the SDK and giving it a 0 length input resulted in a parsing error since we expected a KubeObject to be parsed from said input. This is now handled in this PR.
Added some extra unit tests for things I ran unto during debugging.