fix: catch verification checklist query leaks - #7
Draft
kkkhs wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The audit suspect pass now catches the two recorded verification/checklist leaks from
cmtf8woru, including the keyword-extracted variant.Why
Fixes #6. The previous structural heuristic missed these because they had no terminal punctuation, no leading imperative, and only used generic
verification/candidatewords without one of the existing artifact compounds.Checks
pnpm typecheckcleanpnpm testpasses (Postgres + Redis up — see README for what runs without them)pnpm testwas attempted on this devbox, but Docker/Postgres/Redis are not available here. The no-services run still reached 488 passing tests, and the targeted audit test passed.If this touches an evidence decision
Anything that changes what earns
CODE_VERIFIED, what a verdict may say, whatreaches memory, or what counts as a relevant source:
tests/audit-query-leak.test.tsadds both real leaked strings from #6 tomustFlag; before the heuristic change, those two cases failed.If this makes the system claim something new