Skip to content

Node 20 is deprecated#90

Merged
krdlab merged 8 commits into
krdlab:masterfrom
MRK2009:master
May 11, 2026
Merged

Node 20 is deprecated#90
krdlab merged 8 commits into
krdlab:masterfrom
MRK2009:master

Conversation

@MRK2009
Copy link
Copy Markdown
Contributor

@MRK2009 MRK2009 commented May 6, 2026

Comment thread .github/workflows/test.yml Outdated
Copy link
Copy Markdown
Owner

@krdlab krdlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MRK2009, thanks for the PR, and for also updating actions/setup-node in 7529261.

A couple of notes on how I'll merge this:

  • Merge strategy: To keep the upstream-sync merge commits out of master, I'll squash-merge this PR into a single commit covering both action.yml and .github/workflows/test.yml. You'll still be credited as the author of the squashed commit.
  • Remaining follow-ups: Nothing else is needed from your side for this PR. I'll handle the remaining Node 24 follow-ups (.node-version, engines.node, @types/node, and a regenerated dist/) on my side after this is merged.

Thanks again for the contribution!

@MRK2009
Copy link
Copy Markdown
Contributor Author

MRK2009 commented May 9, 2026

Hi @MRK2009, thanks for the PR, and for also updating actions/setup-node in 7529261.

A couple of notes on how I'll merge this:

  • Merge strategy: To keep the upstream-sync merge commits out of master, I'll squash-merge this PR into a single commit covering both action.yml and .github/workflows/test.yml. You'll still be credited as the author of the squashed commit.
  • Remaining follow-ups: Nothing else is needed from your side for this PR. I'll handle the remaining Node 24 follow-ups (.node-version, engines.node, @types/node, and a regenerated dist/) on my side after this is merged.

Thanks again for the contribution!

I'll see, when I have time.
But your welcome

@krdlab
Copy link
Copy Markdown
Owner

krdlab commented May 9, 2026

Looks like our messages crossed — no worries!

For future commits, descriptive subjects such as chore: bump actions/setup-node to v5 make the history easier to scan later. I'll update the squash subject when merging this PR.

Thanks again!

@MRK2009
Copy link
Copy Markdown
Contributor Author

MRK2009 commented May 11, 2026

Yeah, my commit names are based of my expression of what am I doing right/wrong rather than make them very descriptive of what am I actually doing sometimes.

Also I didn't read you're first message in my pr, because I was too focused on fix the node version deprecation until I checked it.

And I've bumped the actions/setup-node once again, because there is pr(#96) which will conflict my pr, when I have v5.0.0 instead of 6.4.0, so yeah.

Your welcome again.

@krdlab krdlab merged commit 4ca5039 into krdlab:master May 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants