Node 20 is deprecated#90
Conversation
krdlab
left a comment
There was a problem hiding this comment.
Hi @MRK2009, thanks for the PR, and for also updating actions/setup-node in 7529261.
A couple of notes on how I'll merge this:
- Merge strategy: To keep the upstream-sync merge commits out of
master, I'll squash-merge this PR into a single commit covering bothaction.ymland.github/workflows/test.yml. You'll still be credited as the author of the squashed commit. - Remaining follow-ups: Nothing else is needed from your side for this PR. I'll handle the remaining Node 24 follow-ups (
.node-version,engines.node,@types/node, and a regenerateddist/) on my side after this is merged.
Thanks again for the contribution!
I'll see, when I have time. |
|
Looks like our messages crossed — no worries! For future commits, descriptive subjects such as Thanks again! |
|
Yeah, my commit names are based of my expression of what am I doing right/wrong rather than make them very descriptive of what am I actually doing sometimes. Also I didn't read you're first message in my pr, because I was too focused on fix the node version deprecation until I checked it. And I've bumped the Your welcome again. |
https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/