Allow configuring certificate key type (RSA/ECDSA)#95
Open
pigam wants to merge 4 commits intokrtab:mainfrom
Open
Allow configuring certificate key type (RSA/ECDSA)#95pigam wants to merge 4 commits intokrtab:mainfrom
pigam wants to merge 4 commits intokrtab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
This PR adds a
key_typefield to the certificate configuration, allowing users to choose the cryptographic scheme used when generating the certificate private key.Supported values
ecdsa_p256(default, preserves existing behavior)rsa_2048rsa_3072rsa_4096Changes
src/config.rs: newCertKeyTypeenum, newkey_typefield onCertificatesrc/main_logic.rs: newgenerate_private_key()function dispatching onkey_typeintegration-testing/: three new test certificates (RSA 2048, RSA 4096, ECDSA P-256 explicit) with verification of key type and certificate algorithmREADME.md: documentation of the new fieldBackward compatibility
Existing configuration files without
key_typecontinue to work unchanged (ecdsa_p256is the default).