Skip to content

Add constants for bulk profiles#31

Open
bharathappali wants to merge 2 commits into
kruize:mvp_demofrom
bharathappali:feat-bulk-prof-1
Open

Add constants for bulk profiles#31
bharathappali wants to merge 2 commits into
kruize:mvp_demofrom
bharathappali:feat-bulk-prof-1

Conversation

@bharathappali

@bharathappali bharathappali commented Jun 25, 2026

Copy link
Copy Markdown
Member

This PR adds constants for bulk profiles

Summary by Sourcery

New Features:

  • Add constants for the bulk profiles API endpoint and profile name in the optimizer client.

Signed-off-by: bharathappali <abharath@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds new constants to support bulk profile API endpoints alongside existing bulk API constants in OptimizerConstants.

File-Level Changes

Change Details Files
Introduce constants for bulk profile API endpoints to align client and service usage.
  • Add BULK_PROFILES_ENDPOINT constant to represent the bulk profiles API path
  • Add PROFILE_NAME constant to standardize the profile name field in bulk profile requests/responses
  • Group new constants under a dedicated bulk profile APIs section near existing bulk API constants
src/main/java/com/kruize/optimizer/utils/OptimizerConstants.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider aligning BULK_PROFILES_ENDPOINT with existing endpoint naming conventions (e.g., snake-case or nested paths like /bulk/profiles) to keep API URLs consistent across the service.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider aligning `BULK_PROFILES_ENDPOINT` with existing endpoint naming conventions (e.g., snake-case or nested paths like `/bulk/profiles`) to keep API URLs consistent across the service.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bharathappali
bharathappali changed the base branch from main to mvp_demo June 25, 2026 12:10
@bharathappali bharathappali moved this to Under Review in Monitoring Jun 26, 2026
Signed-off-by: bharathappali <abharath@redhat.com>

@kusumachalasani kusumachalasani left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@khansaad khansaad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Under Review

Development

Successfully merging this pull request may close these issues.

3 participants