Conversation
bmike
suggested changes
Feb 21, 2018
Contributor
bmike
left a comment
bmike
left a comment
There was a problem hiding this comment.
Good change rather than failing. Tests well on 10.12 and 10.13 but fails on 10.9 and lower since "9" isn't < "12"
Perhaps change line 11 to use -lt operator instead of <
Contributor
|
To be clear - I'd still merge this change. It fails less often in 10.10 through 10.13 and still fails the same with the same error as the original script for 10.9 and older OS. |
bmike
reviewed
Feb 21, 2018
Author
|
wew this is old ... maybe it's time she merges :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the AssetCacheLocatorUtil binary is part of macOS Sierra, add check to ensure machines running versions less than 12 don't attempt to run the command.