Skip to content

feat: select Registry resources in cluster forms - #428

Merged
lixd merged 3 commits into
kubeclipper:masterfrom
lixd:codex/registry-image-registry
Jul 22, 2026
Merged

feat: select Registry resources in cluster forms#428
lixd merged 3 commits into
kubeclipper:masterfrom
lixd:codex/registry-image-registry

Conversation

@lixd

@lixd lixd commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR updates cluster creation, template creation, upgrade, confirmation, and detail views for the Registry-resource image model introduced by kubeclipper/kubeclipper#975.

  • replaces the free-text image repository input with a select containing configured Registry resources;
  • submits the selected Registry resource name as imageRegistry;
  • displays options as name (scheme://host) while keeping the resource name as the value;
  • adds explicit labels and help text explaining that the field selects an existing Registry resource;
  • updates confirmation, detail, mapper, defaults, and English/Chinese locale strings.

Which issue(s) this PR fixes:

Related to kubeclipper/kubeclipper#973

Special notes for reviewers:

Backend PR: https://github.com/kubeclipper/kubeclipper/pull/975

Validation performed:
- yarn build
- deployed dist to sh-dev-3 and verified the cluster-create form through an SSH tunnel
- selected image-repo and verified that the backend stored imageRegistry: image-repo
- completed a real cluster creation using the selected Registry resource

Does this PR introduced a user-facing change?

Cluster image configuration now selects an existing Registry resource instead of accepting a free-text image repository.

Additional documentation, usage docs, etc.:

- [Other doc]: https://github.com/kubeclipper/kubeclipper/pull/975

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

lixd added 2 commits July 22, 2026 14:25
Signed-off-by: lixd <xueduan.li@gmail.com>
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
lixd force-pushed the codex/registry-image-registry branch from 6c57481 to 5b131ae Compare July 22, 2026 06:25
Signed-off-by: lixd <xueduan.li@gmail.com>

@lixd lixd left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lixd
lixd merged commit 6076e8c into kubeclipper:master Jul 22, 2026
4 checks passed
@lixd
lixd deleted the codex/registry-image-registry branch July 22, 2026 07:04
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.30%. Comparing base (c8ec5fe) to head (ab9484f).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   47.30%   47.30%           
=======================================
  Files           7        7           
  Lines         613      613           
  Branches      176      176           
=======================================
  Hits          290      290           
  Misses        250      250           
  Partials       73       73           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant