feat: select Registry resources in cluster forms - #428
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Signed-off-by: lixd <xueduan.li@gmail.com>
Signed-off-by: lixd <xueduan.li@gmail.com>
lixd
force-pushed
the
codex/registry-image-registry
branch
from
July 22, 2026 06:25
6c57481 to
5b131ae
Compare
Signed-off-by: lixd <xueduan.li@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 47.30% 47.30%
=======================================
Files 7 7
Lines 613 613
Branches 176 176
=======================================
Hits 290 290
Misses 250 250
Partials 73 73 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
This PR updates cluster creation, template creation, upgrade, confirmation, and detail views for the Registry-resource image model introduced by kubeclipper/kubeclipper#975.
imageRegistry;name (scheme://host)while keeping the resource name as the value;Which issue(s) this PR fixes:
Related to kubeclipper/kubeclipper#973
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: