Skip to content

fix: keep navigation on single-character cluster details - #430

Merged
lixd merged 1 commit into
kubeclipper:masterfrom
lixd:codex/fix-cluster-detail-nav
Jul 22, 2026
Merged

fix: keep navigation on single-character cluster details#430
lixd merged 1 commit into
kubeclipper:masterfrom
lixd:codex/fix-cluster-detail-nav

Conversation

@lixd

@lixd lixd commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/kind bug
/kind regression

What this PR does / why we need it:

Fixes the cluster-detail menu route matcher so single-character cluster IDs keep the left navigation visible.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

The previous pattern required at least two characters after /cluster/, so /cluster/c did not match and the menu rendered nothing.

Does this PR introduced a user-facing change?

Fix missing left navigation on cluster detail pages whose cluster ID has one character.

Additional documentation, usage docs, etc.:


@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
lixd force-pushed the codex/fix-cluster-detail-nav branch from 2ce6176 to 784adfb Compare July 22, 2026 10:18

@lixd lixd left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lixd
lixd merged commit 7a637bd into kubeclipper:master Jul 22, 2026
4 checks passed
@lixd
lixd deleted the codex/fix-cluster-detail-nav branch July 22, 2026 10:37
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.30%. Comparing base (c8ec5fe) to head (784adfb).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   47.30%   47.30%           
=======================================
  Files           7        7           
  Lines         613      613           
  Branches      176      176           
=======================================
  Hits          290      290           
  Misses        250      250           
  Partials       73       73           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant