test: Add test coverage for milvus_search and execute_tool #38
Open
Siva-Sainath wants to merge 1 commit intokubeflow:mainfrom
Open
test: Add test coverage for milvus_search and execute_tool #38Siva-Sainath wants to merge 1 commit intokubeflow:mainfrom
Siva-Sainath wants to merge 1 commit intokubeflow:mainfrom
Conversation
Signed-off-by: Siva-Sainath <siva.explores06@proton.me>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial test coverage for core retrieval and tool-execution logic in
app.pyTests added
Support
Justification
These functions are the heart of the current RAG pipeline.
Tests are isolated with realistic mocks which follow deterministic patterns that catch regressions without flakiness
These tests represent the foundation, intend to add coverage for streaming, endpoints, frontend, pipelines or any of the new features that will be added to the codebase