feat: add config validation in predicted-latency-scorer plugin #1904
+209
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
googs1025
force-pushed
the
fix/slo_plugin
branch
from
2fda22a to
1b28116
Compare
Contributor
|
/cc @kaushikmitr |
Member
Author
|
@kaushikmitr /PTAL 😄 |
kaushikmitr
reviewed
Dec 4, 2025
| errs = append(errs, fmt.Errorf("epsilonExploreNeg must be in [0, 1], got %f", c.EpsilonExploreNeg)) | ||
| } | ||
|
|
||
| if c.AffinityGateTau <= 0 || c.AffinityGateTau > 1 { |
Contributor
There was a problem hiding this comment.
AffinityGateTau can be 0
Signed-off-by: CYJiang <googs1025@gmail.com>
googs1025
force-pushed
the
fix/slo_plugin
branch
from
1b28116 to
29f9331
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
+1 this looks good |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes None
Does this PR introduce a user-facing change?: