Update swagger v2 test data from Kubernetes v1.8 to v1.35#581
Open
bryantbiggs wants to merge 1 commit intokubernetes:masterfrom
Open
Update swagger v2 test data from Kubernetes v1.8 to v1.35#581bryantbiggs wants to merge 1 commit intokubernetes:masterfrom
bryantbiggs wants to merge 1 commit intokubernetes:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bryantbiggs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Replace swagger v2 test fixtures (swagger.json, swagger_next.json) with trimmed extracts from the Kubernetes v1.35.2 OpenAPI spec. - Update all test references from deprecated apps/v1beta1 to GA apps/v1 - Fix Container required-field assertions (only 'name' is required in modern Kubernetes, not 'name' and 'image') - Add selector to Deployment validation test (required in apps/v1) - Update DeploymentStatus.conditions extension assertions to include x-kubernetes-list-map-keys and x-kubernetes-list-type OpenAPI v3 test data (v1.24) is left unchanged pending a fix for the proto v3 parser's lack of allOf-wrapped $ref support (see kubernetes#477).
bryantbiggs
force-pushed
the
update-proto-testdata-to-k8s-1.35
branch
from
3ac6c7e to
ce3de3e
Compare
bryantbiggs
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swagger.json,swagger_next.json) with trimmed extracts from the Kubernetes v1.35.2 OpenAPI specapps/v1beta1to GAapps/v1Containerrequired-field assertions (imageis no longer required)selectorto Deployment validation test (required inapps/v1)DeploymentStatus.conditionsextension assertions to includex-kubernetes-list-map-keysandx-kubernetes-list-typeOpenAPI v3 test data (v1.24) is left unchanged pending a fix for the proto v3 parser's lack of
allOf-wrapped$refsupport (see #477 #583 and #584).Resolves feedback from #579 (comment)