Skip to content

throwaway: validate full-ACID + write-gate-sharing (storage prototype/full-acid-containerprofile) — rerun 2/3 — do not merge - #968

Closed
matthyx wants to merge 1 commit into
mainfrom
throwaway/validate-fullacid-writegate-rerun2
Closed

matthyx wants to merge 1 commit into
mainfrom
throwaway/validate-fullacid-writegate-rerun2

Conversation

@matthyx

@matthyx matthyx commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Real-CI validation run 2/3, same image (quay.io/matthiasb_1/storage:fullacid-02002737)
and config overrides as the first run — rerun for noise-floor discipline
(a single CI run has proven unreliable for drawing conclusions in this
investigation).

Throwaway PR, not for merge.

AI-skills: ralplan,plan | cmds: /compact,/usage-credits

…/full-acid-containerprofile) — do not merge

Pins storage.image to quay.io/matthiasb_1/storage:fullacid-02002737, a
build of kubescape/storage prototype/full-acid-containerprofile at commit
02002737 (the SQLite-native ObjectStore ContainerProfile backend, the
write gate hoisted out and shared across all resource kinds, the startup
migration, cleanup/GNP rewiring through the CP store, and the
export-based rollback tool).

Also overrides tests/chart's storage config.json to actually exercise the
new code path: containerProfileSqliteBackend=true, plus an explicit
singleWriterEnabled=true (already the default, set explicitly here since
the backend's own startup check refuses to run without it). Without this,
the deployed storage pod would silently keep serving ContainerProfiles
through the unchanged legacy row+gob-file StorageImpl, defeating the
point of this validation run.

Throwaway PR, not for merge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LCMGT6Po2tSr1VEDVrbbYd
@matthyx matthyx added the ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin) label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: deb83087-aa96-48e7-b5cd-f6db2d075c5d

📥 Commits

Reviewing files that changed from the base of the PR and between 349c642 and 2f2f03a.

📒 Files selected for processing (2)
  • .github/workflows/component-tests.yaml
  • tests/chart/templates/storage/configmap.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Performance Benchmark Results

Node-Agent Resource Usage
Metric BEFORE AFTER Delta
Avg CPU (cores) 0.201 0.192 -4.2%
Peak CPU (cores) 0.206 0.199 -3.5%
Peak CPU p95 (cores) 0.206 0.198 -3.9%
Avg Memory (MiB) 386.917 316.144 -18.3%
Peak Memory (MiB) 390.555 328.609 -15.9%
Dedup Effectiveness

No data available.

@matthyx

matthyx commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Rerun 2/3 of the full-ACID validation, data folded into the summary on #967. Closing as throwaway, not for merge.

@matthyx matthyx closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant