ci: cap component-tests jobs at 30 minutes - #973
Merged
Conversation
A stuck post-step (e.g. actions/setup-go's cache-save) can otherwise run for the full 6-hour hosted-runner ceiling, and GitHub never flushes a force-cancelled job's log tail -- turning an unrelated infra stall into an undiagnosable multi-hour mystery. go test's own --timeout=20m already bounds real test hangs; this just bounds everything else around it too. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCMGT6Po2tSr1VEDVrbbYd
matthyx
added
the
ai-assisted
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe component-tests workflow job now stops after 30 minutes. ChangesComponent test execution
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A stuck post-step (observed:
actions/setup-go@v4's cache-save, unrelated to the actual test) can otherwise run for the full 6-hour hosted-runner ceiling, and GitHub never flushes a force-cancelled job's log tail — turning an unrelated infra stall into an undiagnosable multi-hour mystery instead of a quick, log-intact failure.Change
Adds
timeout-minutes: 30to thecomponent-testsjob.go test's own--timeout=20malready bounds real test hangs; this bounds everything else around it (cluster setup, helm install, post-steps) too, with enough headroom above the slowest observed real runs (~12 min forRun teston the heaviest matrix entries).Context
Found while investigating an apparent 6-hour hang during unrelated storage-backend validation — traced via GitHub's own per-step job metadata to this exact failure mode (job's real work completed successfully in ~9 minutes; the post-step then stalled for the remaining ~6 hours with no way to tell from the truncated log).
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01LCMGT6Po2tSr1VEDVrbbYd
https://claude.ai/code/session_01LCMGT6Po2tSr1VEDVrbbYd
AI-skills: ralplan,plan | cmds: /compact,/usage-credits
Summary by CodeRabbit